closed livingstoneonline/livingstoneonline#214

Overview gray lines

awisnicki

See screen shot. This issue appears to be present on all pages with a TOC. screen shot 2017-09-14 at 12 03 03

nigelgbanks

Gotta edit all those pages to move it into the overview field.

awisnicki

So you're suggesting taking all the TOCs and moving them into the overview section?

I'm wondering if it wouldn't be easier to leave things as is here, so the following would be needed:

  1. In-text <hr/>s need to be made darker. This is true regardless of whether we make other changes, as I believe we might occasionally use <hr>s elsewhere in the site.
  2. The overview section as a rule should not have a gray line below. That's how it was set up before, so to compensate we always started the main text with an <hr>.

I think this is all that is needed to get around the issue of moving all the TOCs (of which there are many). But happy to hear your thoughts on how to approach this.

nigelgbanks

I'm gonna move them into the overview section, it won't take too long and it's the less hacky of the two solutions. I'll change the styling of the hr to match that of the overview as well (the overview doesn't actually use hr tag it just uses border property.

awisnicki

Agreed that it's less hacky! I just didn't want to add extra work. I'll leave it with you then. Just let me know when you want me to review.

nigelgbanks

All the pages affected have now been changed.

awisnicki

This looks good. Thank you very much for doing this.

Could you please make the following minor theming adjustments. Also see screen shots.

The overview section contains black text. Please increase the margin bottom on this to 16px. screen shot 2017-09-21 at 11 03 41

The overview section also contains blue (hyperlinked) text -- the TOCs you just moved. Please reduce the margin botton on this to 6px and increase the line height to 1.6 screen shot 2017-09-21 at 11 00 41 screen shot 2017-09-21 at 11 01 17

Finally, this is unrelated to the above but is a similar kind of theming change. Please increase the margin-bottom on the critical ed dropdown to 26px. screen shot 2017-09-21 at 11 09 22

nigelgbanks

K other changes are now pushed

awisnicki

All changes on this look good, except the space below the hyperlinked table still needs slightly to be reduced. See screen shot. screen shot 2017-09-25 at 09 24 32

nigelgbanks

Should be sorted now.

awisnicki

All looks great. Thank you!